search

BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 197 forks source link

Fix allUniqueChars function #618

Closed caffeinewriter closed 7 years ago

caffeinewriter commented 7 years ago

There is currently a method called allUniqueChars that lives in /lib/allUniqueChars.js. It is incomplete and needs to be fixed!

allUniqueChars takes a string, and returns true if the string contains only unique characters, false if it contains duplicates, and throws an error on invalid/unexpected input.

Acceptance Criteria:

  1. Running yarn test allUniqueChars results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

caffeinewriter commented 7 years ago

Requires #617 to be merged first.

jamesg1 commented 7 years ago

Hi I'd like do this one, thanks!