BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 197 forks source link

Fix convertBytesToKilobytes method #629

Closed jamesg1 closed 7 years ago

jamesg1 commented 7 years ago

There is currently a method called convertBytesToKilobytes that lives in /lib/convertBytesToKilobytes.js. It is incomplete and needs to be fixed!

The method should take a number in bytes and return the equivalent in Kilobytes. More information about bits and bytes can be found here.

Acceptance Criteria:

  1. Running yarn test convertBytesToKilobytes results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

jamesg1 commented 7 years ago

Dependent on PR #628 being merged first.

newbazz commented 7 years ago

imagey can anyone help me out am i facing this error.

jamesg1 commented 7 years ago

Hey @newbazz you need to update your node version as it is out of date for yarn. You can install node from here https://nodejs.org/en/download/ or use node version manager https://github.com/creationix/nvm so you can switch between node versions easily.

MSSR-code commented 7 years ago

I've updated the node as specified about but I'm getting a similar error screenshot 28

BlakeGuilloud commented 7 years ago

Hey @MSSR-code - it looks like you haven't run yarn install in your ganon repo. Jest is a dependency we use for our unit tests, so you must first install it. Try running yarn or yarn install and then run your tests.

jamesg1 commented 7 years ago

@MSSR-code Make sure to read the Readme - https://github.com/BlakeGuilloud/ganon/blob/master/README.md