BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 197 forks source link

Fix isEmailAddress #645

Closed Soben closed 7 years ago

Soben commented 7 years ago

There is currently a method called isEmailAddress that lives in /lib/isEmailAddress.js. It is incomplete and needs to be fixed!

isEmailAddress is a function to return true or false if the email is a valid address. Checks for support for special characters like +

Acceptance Criteria:

  1. Running yarn test isEmailAddress results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

Soben commented 7 years ago

@davcs86 , you told me you wanted to know when this one was available.

davcs86 commented 7 years ago

Yep, thanks @Soben