search

BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 197 forks source link

fix volumeOfCylinder #766

Closed jmknoll closed 6 years ago

jmknoll commented 7 years ago

There is currently a method called volumeOfCylinder that lives in /lib/volumeOfCylinder.js. It is incomplete and needs to be fixed!

This function expects two dimensions of a cylinder (height and radius of base) as inputs, and returns the volume of the cylinder.

Acceptance Criteria:

  1. Running yarn test volumeOfCylinder results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

mwangialfred commented 6 years ago

@BlakeGuilloud I would like to work on this. Thanks Alfred

BlakeGuilloud commented 6 years ago

You got it!

mwangialfred commented 6 years ago

I did not get time to work on this last night. I will work on it today.