BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 197 forks source link

Surface area of Frustum #775

Open jsjain opened 6 years ago

jsjain commented 6 years ago

There is currently a method called surfaceAreaOfFrustum that lives in /lib/surfaceAreaOfFrustum.js. It is incomplete and needs to be fixed!

It expects 3 args smaller radius r1, bigger radius r2 and height h with a fourth optional parameters to return Total surface area or Lateral Surface Area. By default method will return Total Surface Area .

Acceptance Criteria:

  1. Running yarn test surfaceAreaOfFrustum results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!