fix: resolve volume of frustum

BlakeGuilloud / ganon

A javascript library

MIT License

92 stars 196 forks source link

fix: resolve volume of frustum #808

Closed jacksjm closed 2 years ago

jacksjm commented 2 years ago

Closes #773

[X] Running yarn lint does not trigger any linter errors
[x] The test of the method you have fixed is passing
[X] You have written a new skeleton method for someone else to work on!
[X] You have written tests to accompany your skeleton method

jacksjm commented 2 years ago

Hi! I needed to change and put one more decimal value in the result comparison! :tada:

Please label hacktoberfest for me :laughing:

ktilcu commented 2 years ago

We added the hacktoberfest topic too! Happy Hacking!

ktilcu commented 2 years ago

Please make a new issue for your new skeleton!

jacksjm commented 2 years ago

Very Thanks! Sorry but the label is hacktoberfest-accepted :disappointed: I will opened issue too

ktilcu commented 2 years ago

we added the topic to the whole repo. so we don't need the special labels.

Look for the 'hacktoberfest' topic to know if a project is participating in Hacktoberfest.

A pull request is considered approved once it has an overall approving review from maintainers, or has been merged by maintainers, or has been given the 'hacktoberfest-accepted' label.