search

BlakeRhodes / rotato

This is a pairing program to aid those who are pairing up.
https://www.rotato.dev
MIT License
1 stars 3 forks source link

Update rotation logic so that carrying devs stay on the same board #30

Closed giunto closed 3 years ago

giunto commented 3 years ago

This pull request includes the most of the updated carrying logic mentioned in #21, It does not include marking pairs as sticking when all devs in a pair are marked as carrying.

This pull request also backfills all of the tests for the rotation service. I tried to make the tests as agnostic as possible to the actual randomizing and pairing logic, which required a lot of weird helper methods for testing the edge cases in the rotation service. If there's anything that seems unnecessary or can be refactored let me know.

I also fixed the indentation in some of the other files I made so that everything is 2 spaces instead of 4.

BlakeRhodes commented 3 years ago

I like the way that you are mocking out the localStorageService. I think I could use something like that on other work projects.

BlakeRhodes commented 3 years ago

I will deploy these changes probably over lunch, or after work.