search

BlakeRhodes / rotato

This is a pairing program to aid those who are pairing up.
https://www.rotato.dev
MIT License
1 stars 3 forks source link

User should have the option to manually put unused boards in rotation #32

Closed giunto closed 3 years ago

giunto commented 3 years ago

There isn't an easy way to manually assign people to a newly created or unused board. In order to accomplish this the pairs need to be rotated first and rearranged so that the desired devs are tied to the board. I think it would be a nice feature if users could manually put unused boards in rotation if they wanted a pair to be tied to a specific board. This feature would also go well with the updated carrying logic since carried boards are now recognized.

I was thinking of just adding an add button to any available boards that aren't in rotation. It would function the same way as adding a blank pairing slot, except it would contain the board. That seemed like the simplest way to accomplish this, but if you have any thoughts (or issues with this feature in general) let me know.

BlakeRhodes commented 3 years ago

I took a stab at this one. I think this is the functionality you were looking for. If it is I will merge. https://github.com/BlakeRhodes/rotato/tree/add-unused-board

giunto commented 3 years ago

Yeah that's the functionality I was looking for. What's funny is I started to implement this one too. I think it was pretty much done except for some tests. I think the only difference in our implementations is that in yours the add button always shows and in mine it's hidden if the board is not in rotation or disabled.

I like your implementation better, so I'm good with you merging it in. Here's mine in case you have any constructive criticism: https://github.com/BlakeRhodes/rotato/tree/put-boards-in-rotation