search

BlakeWilliams / Elixir-Slack

Slack real time messaging and web API client in Elixir
MIT License
675 stars 182 forks source link

user.name being replaced by user.profile.display_name #169

Closed nmohoric closed 4 years ago

nmohoric commented 6 years ago

Any plans for handling this as it seems like the name attribute is being deprecated? https://api.slack.com/changelog/2017-09-the-one-about-usernames

There is no actual specific date of them getting rid of the name attribute but a lot of lookups rely on it, and they seem to be saying they're going to start getting rid of the old username after September 12

agis commented 6 years ago

@BlakeWilliams any updates on this one?

BlakeWilliams commented 6 years ago

I haven't had a lot of time recently to look into this. I'd happily accept a PR if someone wants to do a bit of research and figure out what's necessary to move forward.

jameskbride commented 5 years ago

I put together a PR to partially address this change. See https://github.com/BlakeWilliams/Elixir-Slack/pull/188 . I say partially because according to the documentation looking up the username now requires reading users.list and finding the latest user_id match by username, which seems like a much bigger lift.

@BlakeWilliams If you get a chance could you take a look at this and let me know what you think please? Thanks in advance!

BlakeWilliams commented 5 years ago

@jameskbride Great, I was just taking a peek at one of the PR's you closed. I'll try to get around to taking a look at it today or tomorrow.

BlakeWilliams commented 5 years ago

Also thanks for diving in and working on these issues ✨

jameskbride commented 5 years ago

Thanks @BlakeWilliams, glad to help!