search

BlakeWilliams / Elixir-Slack

Slack real time messaging and web API client in Elixir
MIT License
675 stars 182 forks source link

added conversations methods to web api #200

Closed m1dnight closed 4 years ago

m1dnight commented 5 years ago

I have added all the conversation API methods. I have done so by copy/pasting them from the website and using some emacs macros. I have not tested all of them, except the history one. I did make sure the mix test task succeeds.

Couple of remaining questions I have:

Please tell me you did not have an automation script for this?
Do you need to me to verify they all work somehow?

(This time without .DS_Store files :)

BlakeWilliams commented 5 years ago

@m1dnight Woah, this is rad!

Can you verify at least a handful of them work? If so I'd be more than happy to merge and publish another release.

m1dnight commented 5 years ago

Sure can! Give me some time to get that working.

fozcodes commented 4 years ago

@m1dnight Thanks for doing this! I'm happy to take a look and verify it's working if you haven't had time. I definitely need this for something I'm working on.

fozcodes commented 4 years ago

Hey @BlakeWilliams & @m1dnight - I made a PR to this fork that has a couple of fixes to get this working. I've verified they're all good if you can merge it in @m1dnight https://github.com/m1dnight/Elixir-Slack/pull/1 . Or I'm happy to throw up another PR directly here.

Cheers!

m1dnight commented 4 years ago

Hey, thanks for this. I've been swamped with work lately and have not had the time to look at this. Really appreciate this!

acconrad commented 4 years ago

@fozcodes @m1dnight can you work to get this resolved? i think a bunch of this is already in the docs folder as it is

acconrad commented 4 years ago

This is another one we can close because these files already exist in the API docs folder