Adds oauth.v2.access method

BlakeWilliams / Elixir-Slack

Slack real time messaging and web API client in Elixir

MIT License

675 stars 182 forks source link

Adds oauth.v2.access method #209

Closed jmnsf closed 4 years ago

jmnsf commented 4 years ago

Docs: https://api.slack.com/methods/oauth.v2.access

This implies a breaking change: the current module generator is mapping multi-level endpoint names to functions with dashes in the name. For example, oauth.v2.access becomes Slack.Web.Oauth.v2/access/3.

This, while valid, makes it very dificult to call the function and I believe was unintended. This PR changes the generator so that the above endpoint becomes Slack.Web.Oauth.V2.access/3.

BlakeWilliams commented 4 years ago

That is awkward API wise, and definitely unintended.

Since we're pre-1.0 breaking changes here are fine imo but it'd be nice to start documenting those breaking changes if possible. Either way, merging this for now. Thanks for the contribution!