BlakesHeaven / Simple-Stats-Plus

This repository combines and enhances Bludits Simple stas and Hit Counter
MIT License
5 stars 2 forks source link

Incompatible with Search Plugin #11

Closed RalfKerkhoff closed 3 years ago

RalfKerkhoff commented 3 years ago

Hi, activating the plugin will lead to a blank page when a search is performed with the standard search plugin. No error message, simply a blank page. Disabling simple stats plus makes search working again.

And there themes a problem with the de_DE language file. If Bludit is set to german, the Plugin name and the description is empty in Bludit backend.

Cheers Ralf

RalfKerkhoff commented 3 years ago

Update - found a soution for the search problem:

In Bludit's settings under the advanced tab, the pages are set to "/" wich means articles are displayed in the frontend like: https://yoursite.com/articlename

Solution: change the "/" to something like "/articles/" (without the quotes). Articles will now be displayed as: https://yoursite.com/articles/articlename

This will make the search work without any problems.

Still open is the problem with the language file

BlakesHeaven commented 3 years ago

Hey @RalfKerkhoff , thanks for reporting. I have replicated both.

I have pushed up a fix for the language file but not yet sorted the release for it. In the meantime, please look for

Replace the double quote around "Versteckt" with single quotes as 'Versteckt'

I think I know whereabouts the other strange issue is being caused, but need to fix it properly.

In the meantime, with your workaround in place and both working and some visits counted, I think you can revert your workaround back to just "/" instead of "/articles/" and it will still work. Scratch this...

I'll leave this open for now.

BlakesHeaven commented 3 years ago

The page counting part was running at siteBodyBegin() to allow the Hitcounter displayed on the page to be correct from the start, however, there seems to be some incompatibility. Changing the running order back to siteBodyEnd() fixes it so for the sake of being 1 count behind I'll leave it running at the end.