BlakkM9 / speed-dial

2 stars 1 forks source link

settings #1

Open ghost opened 5 years ago

ghost commented 5 years ago

please add settings to hide "white +" squares, is bad for dark theme, maybe an very dark square? Also setting to disable animation when loading.

ghost commented 5 years ago

you can also add context menu to add sites, in bookmark 'n history sidebar context menus, you can also add an title field and an setting to show an tooltip when mouse over the thumb. Also when you add an new dial using context menu, if the mouse is over an image, when you clicked to open menu, use this image as thumb, it can be an optional setting and optional behaviour.

BlakkM9 commented 5 years ago

I'll add this in the next update. The intention behind not being able to change the + squares is that the user can adjust the number of tiles to fit their need. Anyways this is a good idea I didn't think of so far. Disabling the animation can also be added in the next update. These features will propably be available in the advanced settings. Same goes for the advanced context menu.

The problem with adding bookmarks is that this will need the permission to read all users bookmarks and I want to use as few permissions as possible, but I'll think about it. Title will be added after the next update when I made some major code cleanups, because the code is pretty untidy by now and I want to implement everything with classes and module based before adding major content.

Thanks for the feedback!

ghost commented 5 years ago

the bookmark permission can be per demand, an another suggestion, add an new type of "dial", an "Folder Dial" the appearance can be the same as the "default dial", but with mouse over show an little folder icon in the thumb corner, when I click this "Folder Icon" show a new group of dials, you can add an arrow to back, above, for instance, I can add an "Folder Dial" with an Youtube image as thumb, if I click directly in Youtube img, open "youtube.com", and if I click in the "Little Folder Icon" show to me a new group of dials with my fav channels, I can add an custom thumb for each channel using the new context menu img capture :), and an big detail if I click with mouse middle button in the "Little Folder Icon", the extension open all sites in the folder in new tabs. What you think about? Can be very cool.

Thanks so much for attention and answer!

BlakkM9 commented 5 years ago

As far as I know this cannot be done with demand but I'll take a look at this. Usually you have to list all needed permissions in the manifest.json. I think this needs to be done so that they can display all needed permissions for the addon on its page. Anyways, maybe this is possible because it always asks for permission to replace the new tab page.

I was thinking about a group system before but I think your approach really is a much more fluent concept than the one I had in mind so this comes definetly on the TODO list. As this is pretty much work it'll take some time until it's implemented (still a hobby project and the code really needs some cleanup before).

About the context menu: do you mean that there is an additional menu entry when you right click an image to set a thumbnail for any tile, the menu entry changes to "add current page with this image as thumbnail" or that the same entry appears but additional to the default one? I think the secound one would be the best because I'd prefere to keep only one entry for the addon so it doesn't feel like context menu spamming but this might lead to frustration when not explained properly when a webpage has lots of image content, if you know what I mean.

Thanks for the good ideas for improvement (:

ghost commented 5 years ago

I also think better keep only one entry, my idea is so, add an new advanced setting to change the behavior of this current entry, if the user want... About bookmarks sidebar context menu, I think is good an entry with accept also multiselection, for instance if I select just one bookmark can add one "new dial" if is multiple bookmarks user can add multiple dials separately (batch) , add to an new folder, or add to an current folder... An another question, have something to do, to make the extenssion page open fast as the Firefox default home screen? I think is a lot of work absolutely, is just suggestions to you think about. Thanks.

BlakkM9 commented 5 years ago

Yeah options always are the best choice, that's true.

I just checked how it behaves with multiple context menu entries and it groups them like this:

nDSVg0f

That wouldn't be to bad, but I'll take care of this after the serverly needed code cleanup.

What exactly do you mean with your question? Do you mean by setting the checkbox in the advanced options? For me loading the dial in a new tab and loading it when pressing the homepage button almost takes the same time. The big problem with the homepage speeddial is that there would be the possibility to always set it as homepages aswell but I want an option to disable this and also don't want this behavior by default.

Also when I tested it using the chrome_settings_overrides.homepage key in the manifest file I couldn't noice any difference regarding the loading speed.

If you want to improve your loading times you can use images with lower resoltion/less tiles in you dial. Also it's planned to enable image storing locally so that will improve loading times aswell, I hope.

I just added the options for disabling the loading animation and changing the colors of empty tiles. I'll do some more bugfixing for this version and then release it on firefox within the next few hours.

ghost commented 5 years ago

Very good... About loading time, I can see which any "custom new tab extension" is slow to load than the firefox "native new tab" I think mozila keep "the native" on memory. About store images locally I think it essential, another good thing can be support base64 for imgs. Really the context submenu can be fine too...

ghost commented 5 years ago

I updated, here the intro animations isn't completely disabled, have an short animation

thanks again for the attention!

BlakkM9 commented 5 years ago

can you check your version? in 1.6.2 the tick was inverted but I fixed that within the next few hours and removed the buggy version from AMC. Force an update and it should work.

ghost commented 5 years ago

yes, now is ok! thanks!