search

BlamKiwi / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Fixes needed to pass code analysis tools #1005

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Our team runs code analysis tools and it reported some small code issues.  Most 
of these are checks for result codes before accessing output params.  ANGLE has 
ASSERTs which catch these at runtime, but a hand full can be fixed to allow 
code analysis tools to pass.

Original issue reported on code.google.com by co...@microsoft.com on 15 May 2015 at 9:56

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1

commit ab4fd98fac0cbc30cfc578a06c068519ee2df2e1
Author: Cooper Partin <coopp@microsoft.com>
Date: Fri May 15 21:58:22 2015

Small fixes for passing code analysis tools.

BUG=angleproject:1005

Change-Id: I8f2a6c0a5a6157303e436b96cc4c4ff1c29cfe18
Reviewed-on: https://chromium-review.googlesource.com/271600
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/DebugAnnotator11.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/Renderer11.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/SwapChain11.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/Buffer11.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/winrt/CoreWindowNativeWindow.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/winrt/InspectableNativeWindow.cpp
[modify] 
http://crrev.com/ab4fd98fac0cbc30cfc578a06c068519ee2df2e1/src/libANGLE/renderer/
d3d/d3d11/renderer11_utils.h

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 4:22