ANGLE doesn't check that #version 300 es directive is on the first line of the shader

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Run WebGL 2 conformance test 
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/glsl3/misplaced-ve
rsion-directive.html

What is the expected output? What do you see instead?
Expected: Pass
Actual: Fail

Original issue reported on code.google.com by oetu...@nvidia.com on 25 May 2015 at 12:42

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c378cd8aebb56f2617889ba1bba4f871e77aeaba

commit c378cd8aebb56f2617889ba1bba4f871e77aeaba
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Mon May 25 12:21:44 2015

Check that #version 300 es directive is on the first line

ESSL3.00 and 3.10 specs don't allow even newlines before the version
directive.

BUG=angleproject:1009
TEST=WebGL 2 conformance tests, angle_unittests

Change-Id: Id7967829077e35e03572c724e0eafffbed0c975b
Reviewed-on: https://chromium-review.googlesource.com/272719
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

[modify] 
http://crrev.com/c378cd8aebb56f2617889ba1bba4f871e77aeaba/src/compiler/preproces
sor/DiagnosticsBase.cpp
[modify] 
http://crrev.com/c378cd8aebb56f2617889ba1bba4f871e77aeaba/src/compiler/preproces
sor/DirectiveParser.cpp
[modify] 
http://crrev.com/c378cd8aebb56f2617889ba1bba4f871e77aeaba/src/tests/compiler_tes
ts/MalformedShader_test.cpp
[modify] 
http://crrev.com/c378cd8aebb56f2617889ba1bba4f871e77aeaba/src/compiler/preproces
sor/DiagnosticsBase.h

Original comment by bugdroid1@chromium.org on 27 May 2015 at 6:01

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 27 May 2015 at 6:15

Changed state: Fixed

BlamKiwi / angleproject

ANGLE doesn't check that #version 300 es directive is on the first line of the shader #1009