ANGLE rejects shaders with GL_MAX_ATTRIBS attributes

GoogleCodeExporter commented 9 years ago

We have an off-by-one error here, where we are calling >= instead of > in our 
program linking validation. This is a regression which seems to have slipped 
though a gap in our test coverage.

Original issue reported on code.google.com by jmad...@chromium.org on 15 Jun 2015 at 6:08

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3f3d75ea6c20826adb6240f1573fd7139939a986

commit 3f3d75ea6c20826adb6240f1573fd7139939a986
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 18:10:42 2015

Fix support for GL_MAX_ATTRIBS attributes.

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: Iddfe0c21bef3c3a61017ba56d9e1fc001c0a3703
Reviewed-on: https://chromium-review.googlesource.com/277476
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

[modify] 
http://crrev.com/3f3d75ea6c20826adb6240f1573fd7139939a986/src/tests/gl_tests/Ver
texAttributeTest.cpp
[modify] 
http://crrev.com/3f3d75ea6c20826adb6240f1573fd7139939a986/src/libANGLE/Program.c
pp

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 6:56

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/588e7ed2f8d3cd54f9961fe946ceedc78a967d0d

commit 588e7ed2f8d3cd54f9961fe946ceedc78a967d0d
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 20:59:24 2015

Revert "Fix support for GL_MAX_ATTRIBS attributes."

Breaks the AMD bot's OpenGL tests.

VertexAttributeTest.MaxAttribs/3:
shader compilation failed: Vertex shader failed to compile with the following 
errors:
ERROR: error(#272) Implicit version number 110 not supported by GL3 forward 
compatible context
ERROR: error(#273) 1 compilation errors.  No code generated

shader compilation failed: Fragment shader failed to compile with the following 
errors:
ERROR: error(#272) Implicit version number 110 not supported by GL3 forward 
compatible context
ERROR: error(#273) 1 compilation errors.  No code generated

BUG=angleproject:1045
BUG=500116

This reverts commit 3f3d75ea6c20826adb6240f1573fd7139939a986.

Change-Id: I8cdd024fcf49f1ade553dae2cdbe8b02d8fba364
Reviewed-on: https://chromium-review.googlesource.com/277673
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

[modify] 
http://crrev.com/588e7ed2f8d3cd54f9961fe946ceedc78a967d0d/src/tests/gl_tests/Ver
texAttributeTest.cpp
[modify] 
http://crrev.com/588e7ed2f8d3cd54f9961fe946ceedc78a967d0d/src/libANGLE/Program.c
pp

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 9:01

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/8e695edb8bf013e274597c17310e190080887cd0

commit 8e695edb8bf013e274597c17310e190080887cd0
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 21:00:44 2015

Fix support for GL_MAX_ATTRIBS attributes.

*re-land with fix for AMD/ES2/OpenGL.*

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: If44f809d432221d1e17afc407d49e87e0cb7504c
Reviewed-on: https://chromium-review.googlesource.com/277664
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/gl_tests/Ver
texAttributeTest.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.h
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/libANGLE/Program.c
pp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.h

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 9:42

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/8e695edb8bf013e274597c17310e190080887cd0

commit 8e695edb8bf013e274597c17310e190080887cd0
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 21:00:44 2015

Fix support for GL_MAX_ATTRIBS attributes.

*re-land with fix for AMD/ES2/OpenGL.*

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: If44f809d432221d1e17afc407d49e87e0cb7504c
Reviewed-on: https://chromium-review.googlesource.com/277664
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/gl_tests/Ver
texAttributeTest.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.h
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/libANGLE/Program.c
pp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.h

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 10:19

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/8e695edb8bf013e274597c17310e190080887cd0

commit 8e695edb8bf013e274597c17310e190080887cd0
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 21:00:44 2015

Fix support for GL_MAX_ATTRIBS attributes.

*re-land with fix for AMD/ES2/OpenGL.*

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: If44f809d432221d1e17afc407d49e87e0cb7504c
Reviewed-on: https://chromium-review.googlesource.com/277664
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/gl_tests/Ver
texAttributeTest.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/util/EGLWindow.h
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.cpp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/libANGLE/Program.c
pp
[modify] 
http://crrev.com/8e695edb8bf013e274597c17310e190080887cd0/src/tests/test_utils/a
ngle_test_configs.h

Original comment by bugdroid1@chromium.org on 15 Jun 2015 at 10:27

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/fa9744b09e2478c75a25fd1b497469d429e81591

commit fa9744b09e2478c75a25fd1b497469d429e81591
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jun 15 21:00:44 2015

Fix support for GL_MAX_ATTRIBS attributes.

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: If44f809d432221d1e17afc407d49e87e0cb7504c
Reviewed-on: https://chromium-review.googlesource.com/278240
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

[modify] 
http://crrev.com/fa9744b09e2478c75a25fd1b497469d429e81591/src/libANGLE/Program.c
pp

Original comment by bugdroid1@chromium.org on 17 Jun 2015 at 6:35

Added labels: merge-merged-2403

GoogleCodeExporter commented 9 years ago

Original comment by jmad...@chromium.org on 22 Jun 2015 at 3:23

Changed state: Fixed

BlamKiwi / angleproject

ANGLE rejects shaders with GL_MAX_ATTRIBS attributes #1045