search

BlamKiwi / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Generate an error when seeing a non-preprocessor token before an #extension directive in ESSL3. #1047

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
After attempting to generate this error for current ESSL1 shaders, we found 
that many WebGL shaders already relied on this behaviour.  Since WebGL 2 is not 
released yet, now is a good time to enforce this new rule without breaking 
existing content.

Original issue reported on code.google.com by geofflang@chromium.org on 23 Jun 2015 at 8:36

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b3a6a8f3622fd6443e67a6e89ed36692642fec91

commit b3a6a8f3622fd6443e67a6e89ed36692642fec91
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jun 23 20:10:14 2015

Error when encountering non-preprocessor tokens before #extension in ESSL3.

BUG=angleproject:1047

Change-Id: I4a548270f651e35b2c8d1ab5d0f46185230c5f74
Reviewed-on: https://chromium-review.googlesource.com/281216
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/b3a6a8f3622fd6443e67a6e89ed36692642fec91/src/compiler/preproces
sor/DiagnosticsBase.cpp
[modify] 
http://crrev.com/b3a6a8f3622fd6443e67a6e89ed36692642fec91/src/compiler/preproces
sor/DirectiveParser.cpp
[modify] 
http://crrev.com/b3a6a8f3622fd6443e67a6e89ed36692642fec91/src/tests/preprocessor
_tests/extension_test.cpp
[modify] 
http://crrev.com/b3a6a8f3622fd6443e67a6e89ed36692642fec91/src/compiler/preproces
sor/DirectiveParser.h
[modify] 
http://crrev.com/b3a6a8f3622fd6443e67a6e89ed36692642fec91/src/compiler/preproces
sor/DiagnosticsBase.h

Original comment by bugdroid1@chromium.org on 29 Jun 2015 at 1:58