search

BlamKiwi / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Fix variable collection of gl_DepthRange #991

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We don't capture this builtin uniform in the variable collection step of the 
translator.

Original issue reported on code.google.com by jmad...@chromium.org on 29 Apr 2015 at 3:50

GoogleCodeExporter commented 9 years ago

Original comment by jmad...@chromium.org on 29 Apr 2015 at 3:50

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : f1ae954b660cb058c40665b623f4d689b65180d4

Code-Review  0 : Geoff Lang, Jamie Madill
Code-Review  +2: Zhenyao Mo
Verified     0 : Geoff Lang, Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Ie254132e37c307323ba9e6e1705d138eea67b520
Reviewed-at    : https://chromium-review.googlesource.com/268524

translator: Fix variable collection for gl_DepthRange.

This built-in uniform wasn't being collected in VariableInfo.cpp.
Also remove the existing workaround for D3D gl_DepthRange
collection.

BUG=angleproject:991
BUG=478570

include/GLSLANG/ShaderVars.h
src/compiler/translator/VariableInfo.cpp
src/compiler/translator/VariableInfo.h
src/libANGLE/Shader.h
src/libANGLE/renderer/d3d/ProgramD3D.cpp
src/libANGLE/renderer/d3d/ShaderD3D.cpp
src/tests/compiler_tests/CollectVariables_test.cpp

Original comment by bugdroid1@chromium.org on 1 May 2015 at 6:44

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 26e1a466df4368b246fa0835a2bc33adc6e6201d

Code-Review  0 : Zhenyao Mo
Code-Review  +2: Jamie Madill
Verified     0 : Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I217aba1b32dc0e70d6153337a1f0ccef0483a0e1
Reviewed-at    : https://chromium-review.googlesource.com/268792

Revert "translator: Fix variable collection for gl_DepthRange."

Build errors on Linux:

error: comparison of integers of different signs: 'const int' and 'const 
unsigned int'

BUG=angleproject:991
BUG=478570

This reverts commit f1ae954b660cb058c40665b623f4d689b65180d4.

include/GLSLANG/ShaderVars.h
src/compiler/translator/VariableInfo.cpp
src/compiler/translator/VariableInfo.h
src/libANGLE/Shader.h
src/libANGLE/renderer/d3d/ProgramD3D.cpp
src/libANGLE/renderer/d3d/ShaderD3D.cpp
src/tests/compiler_tests/CollectVariables_test.cpp

Original comment by bugdroid1@chromium.org on 1 May 2015 at 7:20

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 55def58323c359f5ab26c62757edcbe516259ada

Code-Review  0 : Geoff Lang, Zhenyao Mo
Code-Review  +2: Jamie Madill
Verified     0 : Geoff Lang, Zhenyao Mo
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Iba84651bfc58f82fd4ce039421874f561f83c348
Reviewed-at    : https://chromium-review.googlesource.com/268840

translator: Fix variable collection for gl_DepthRange.

*re-land with Linux fixes, and fix for locations*

This built-in uniform wasn't being collected in VariableInfo.cpp.
Also remove the existing workaround for D3D gl_DepthRange
collection.

BUG=angleproject:991
BUG=478570

include/GLSLANG/ShaderVars.h
src/compiler/translator/VariableInfo.cpp
src/compiler/translator/VariableInfo.h
src/libANGLE/Shader.h
src/libANGLE/Uniform.cpp
src/libANGLE/Uniform.h
src/libANGLE/renderer/d3d/ProgramD3D.cpp
src/libANGLE/renderer/d3d/ShaderD3D.cpp
src/tests/angle_end2end_tests.gypi
src/tests/compiler_tests/CollectVariables_test.cpp
src/tests/end2end_tests/GLSLTest.cpp
src/tests/end2end_tests/QueryDisplayAttribTest.cpp

Original comment by bugdroid1@chromium.org on 4 May 2015 at 5:22

GoogleCodeExporter commented 9 years ago

Original comment by jmad...@chromium.org on 5 May 2015 at 4:54