Build angle_end2end_tests on Linux

GoogleCodeExporter commented 9 years ago

Currently we're blocked on a few problems here, one of the major ones being 
that we use a non-standard template syntax where gcc and clang validate more 
strictly. We can fix this particular issue by using value-parameterized tests 
in gtest instead of type-parameterized tests.

Original issue reported on code.google.com by jmad...@chromium.org on 7 May 2015 at 4:35

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : fa05f6076ee3d0372f29e1a1381de035b964be4f

Code-Review  0 : Corentin Wallez, Jamie Madill
Code-Review  +2: Geoff Lang
Verified     0 : Corentin Wallez, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Id1bb15231eda445f37e53a5b33d4684ec6618d8e
Reviewed-at    : https://chromium-review.googlesource.com/269858

Use value-paramaterized tests instead of by type.

This should fix our non-standard template use, which causes compile
errors for the tests on GCC/Clang.

BUG=angleproject:997

src/tests/angle_end2end_tests.gypi
src/tests/end2end_tests/ANGLETest.cpp
src/tests/end2end_tests/ANGLETest.h
src/tests/end2end_tests/BlendMinMaxTest.cpp
src/tests/end2end_tests/BlitFramebufferANGLETest.cpp
src/tests/end2end_tests/BufferDataTest.cpp
src/tests/end2end_tests/ClearTest.cpp
src/tests/end2end_tests/CompressedTextureTest.cpp
src/tests/end2end_tests/CubeMapTextureTest.cpp
src/tests/end2end_tests/DepthStencilFormatsTest.cpp
src/tests/end2end_tests/DrawBuffersTest.cpp
src/tests/end2end_tests/FenceSyncTests.cpp
src/tests/end2end_tests/FramebufferFormatsTest.cpp
src/tests/end2end_tests/FramebufferRenderMipmapTest.cpp
src/tests/end2end_tests/GLSLTest.cpp
src/tests/end2end_tests/IncompleteTextureTest.cpp
src/tests/end2end_tests/IndexedPointsTest.cpp
src/tests/end2end_tests/InstancingTest.cpp
src/tests/end2end_tests/LineLoopTest.cpp
src/tests/end2end_tests/MaxTextureSizeTest.cpp
src/tests/end2end_tests/MipmapTest.cpp
src/tests/end2end_tests/OcclusionQueriesTest.cpp
src/tests/end2end_tests/PBOExtensionTest.cpp
src/tests/end2end_tests/PbufferTest.cpp
src/tests/end2end_tests/PointSpritesTest.cpp
src/tests/end2end_tests/ProgramBinaryTest.cpp
src/tests/end2end_tests/QueryDisplayAttribTest.cpp
src/tests/end2end_tests/ReadPixelsTest.cpp
src/tests/end2end_tests/RendererTest.cpp
src/tests/end2end_tests/SRGBTextureTest.cpp
src/tests/end2end_tests/SimpleOperationTest.cpp
src/tests/end2end_tests/SwizzleTest.cpp
src/tests/end2end_tests/TextureTest.cpp
src/tests/end2end_tests/TransformFeedbackTest.cpp
src/tests/end2end_tests/UniformBufferTest.cpp
src/tests/end2end_tests/UniformTest.cpp
src/tests/end2end_tests/UnpackAlignmentTest.cpp
src/tests/end2end_tests/UnpackRowLength.cpp
src/tests/end2end_tests/VertexAttributeTest.cpp
src/tests/end2end_tests/ViewportTest.cpp
src/tests/end2end_tests/angle_test_configs.h
src/tests/standalone_tests/EGLQueryContextTest.cpp
util/testfixturetypes.h
util/util.gyp

Original comment by bugdroid1@chromium.org on 8 May 2015 at 7:13

GoogleCodeExporter commented 9 years ago

Action item: clean up the test namespaces.

Original comment by jmad...@chromium.org on 8 May 2015 at 7:13

GoogleCodeExporter commented 9 years ago

Corentin: do you want to take charge of getting the tests running on Linux?

Original comment by jmad...@chromium.org on 8 May 2015 at 7:22

GoogleCodeExporter commented 9 years ago

Yes I will do it, it will require adding some platform specific code in common/ 
for EGLThreadTest, OcclusionQueriesTest and QueryDisplayAttribTest IIRC.

Original comment by cwal...@google.com on 8 May 2015 at 7:29

GoogleCodeExporter commented 9 years ago

OK. For the threading test, I'd recommend we do not implement this right now, 
it's a pretty low priority, unless you feel the testing is useful. Implementing 
a Sleep() for Occlusion should be pretty easy, and not sure about 
QueryDisplayAttribTest.

Original comment by jmad...@chromium.org on 8 May 2015 at 7:30

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 440e5d4f9dfa70a362163a624f9bde8d4334fc23

Code-Review  0 : Corentin Wallez, Jamie Madill
Code-Review  +2: Geoff Lang
Verified     0 : Corentin Wallez, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I94a629c50cb6ea6fc0020e3ec9ee93b7088d964b
Reviewed-at    : https://chromium-review.googlesource.com/270108

Roll googletest.

This also moves us to the Chromium googletest mirror. It may cause
conflicts with developer setups if they have the folder open when
they try to gclient sync.

BUG=angleproject:997

DEPS

Original comment by bugdroid1@chromium.org on 11 May 2015 at 2:06

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 6fce6df7e68ab3a9b11c2ef935e6398734a74732

Code-Review  0 : Corentin Wallez
Code-Review  +2: Geoff Lang, Jamie Madill
Verified     0 : Geoff Lang, Jamie Madill
Verified     +1: Corentin Wallez
Commit Queue   : Chumped
Change-Id      : I6aab7d407f260ee24c5c59bf4d6055e875d3a6d6
Reviewed-at    : https://chromium-review.googlesource.com/270184

Filter out unsupported platforms for value parameterized tests

With this most of the end2end tests pass on Linux

BUG=angleproject:997
BUG=angleproject:982

src/tests/end2end_tests/UniformBufferTest.cpp
src/tests/end2end_tests/UnpackAlignmentTest.cpp
src/tests/end2end_tests/UnpackRowLength.cpp
src/tests/end2end_tests/VertexAttributeTest.cpp
src/tests/end2end_tests/angle_test_configs.h
src/tests/standalone_tests/EGLQueryContextTest.cpp

Original comment by bugdroid1@chromium.org on 11 May 2015 at 3:51

BlamKiwi / angleproject

Build angle_end2end_tests on Linux #997