14.09.2023 issue-52: insert chat id, token, token alias into database if token is valid

[iColdLight]

Added dependency for json web token in the pom.xml file Added validateToken method in the TokenController class Modified registerToken method to include validation of token in the TokenController class

---

PR-Codex overview

Focus of the PR:

This PR focuses on adding token validation and insertion functionality to the codebase.

Detailed summary:

• Added TokenValidation class in io.blamer.hub.pg package.
• TokenValidation implements the Tokens interface.
• Added validateAndInsertToken method in TokenValidation to validate and insert tokens.
• Added validateToken method in TokenValidation to validate tokens.
• Added checkIfTokenExists method in TokenValidation to check if a token already exists in the database.
• Added SQL query to check if a token exists in the checkIfTokenExists method.
• Added TokenAlreadyExists exception in io.blamer.hub.exceptions package.
• Added TokenInsertion class in io.blamer.hub.pg package to handle token insertion.
• TokenInsertion implements the Tokens interface.
• Added add method in TokenInsertion to add tokens.
• Modified TokenController class in io.blamer.hub.controller package.
• Modified the TokenController constructor to accept a Tokens object with @Qualifier("tokenValidation").
• Modified the registerToken method in TokenController to use the tokens object to add tokens.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[zoeself]

@iColdLight thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

[zoeself]

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-09-17T19:18:59.313614.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

[zoeself]

@h1alexbel Don't forget to close this ticket before the deadline (2023-09-17T19:18:59). You are past the first half of the allowed period.

[iColdLight]

Does it mean that I need to work on creating JWT TokenProvider, JWT TokenFIlter, JWT User, etc.?

[h1alexbel]

@iColdLight we don't need JWTs. We are dealing with simple text token from GitHub

And this token is not JWT, it's a just simple GitHub token, simple string

[zoeself]

@h1alexbel Looks like you've missed the task deadline (2023-09-17T19:18:59). You are now resigned from this task.

Please stop working on it, you will not be paid. I will assign it to someone else soon.

[zoeself]

@h1alexbel I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

[iColdLight]

Hi! I made new changes. I wonder, if you can see them. And sorry for 3 commits in a row... made slight changes in the last two.

[l3r8yJ]

@iColdLight it's okay with commits, but you can read this

[l3r8yJ]

@h1alexbel reminder

[l3r8yJ]

/codex Could there be a problem here in terms of non-blocking interaction?

[pr-codex[bot]]

Could there be a problem here in terms of non-blocking interaction?

@l3r8yJ Yes, there could be a problem with non-blocking interaction in the code. The TokenValidation class implements the Tokens interface and overrides the add method. Inside the add method, there are multiple database interactions (validateToken, checkIfTokenExists, and this.tokenInsertion.add) that return Mono objects, indicating asynchronous operations.

However, the code does not utilize reactive operators like flatMap, map, or zip to chain these operations together and ensure non-blocking execution. Instead, it directly calls these methods synchronously, which may lead to blocking behavior and potential performance issues.

To ensure non-blocking interaction, the code should use reactive operators to compose the asynchronous operations and handle the results asynchronously.

[l3r8yJ]

@iColdLight take note of this comment

Could there be a problem here in terms of non-blocking interaction?

@l3r8yJ Yes, there could be a problem with non-blocking interaction in the code. The TokenValidation class implements the Tokens interface and overrides the add method. Inside the add method, there are multiple database interactions (validateToken, checkIfTokenExists, and this.tokenInsertion.add) that return Mono objects, indicating asynchronous operations.

However, the code does not utilize reactive operators like flatMap, map, or zip to chain these operations together and ensure non-blocking execution. Instead, it directly calls these methods synchronously, which may lead to blocking behavior and potential performance issues.

To ensure non-blocking interaction, the code should use reactive operators to compose the asynchronous operations and handle the results asynchronously.

it's an AI response, could be wrong

[iColdLight]

I made a change to my TokenValidation class to ensure non-blocking interaction. May you take a look?

[h1alexbel]

@l3r8yJ take a look, please