search

Blankscreen-exe / ColorToGrayScale-converter

It converts colors from html input to their grayscale versions
https://blankscreen-exe.github.io/ColorToGrayScale-converter/
0 stars 2 forks source link

Update readme #10

Closed kyracho closed 2 weeks ago

kyracho commented 2 weeks ago

update preview.png

preview
Blankscreen-exe commented 2 weeks ago

@kyracho I think it's on me. I really appreciate that you took your time out to contribute to my silly projects, but I actually wanted the light version of the page with the zigzag styling that is on the background. Not the dark one.

kyracho commented 2 weeks ago

@Blankscreen-exe No worries at all! I'll go ahead and change it to the light version with the zigzag styling on the background. Also, just a heads-up, the dark mode button isn't working anymore. I apologize if the dark mode button issue was a result of my PR. I’ll work on fixing it!

kyracho commented 2 weeks ago

Sorry for not seeing this sooner! The issue occurred because the original <h1> element used the class .text, which was targeted in the darkMode function. After the dark mode button issue, the element was changed to use an id title instead, causing the darkMode function to fail when trying to apply changes to the now non-existent .text class. To resolve this, I’ll update the function to target the new title id instead of .text, like this:

document.getElementById('title').classList.add('text-white');
Blankscreen-exe commented 2 weeks ago

Thank you for your time and efforts. Much appreciated. 😄