Blazemeter / jmeter-http2-plugin

HTTP2 plugin for Apache JMeter
Apache License 2.0
45 stars 27 forks source link

Http2 plugin installation may discard already installed ones #68

Open syampol13 opened 4 months ago

syampol13 commented 4 months ago

Jmeter: 5.6.2

Observed that Http2 plugin installation may remove some already installed plugins. In my case I had jpgc-graphs-additional,jpgc-graphs-basic,jpgc-casutg installed. And all those were removed with the bzm http installation (without even corresponding warning in plugin-manager)

To reproduce:

  1. Get pure Jmeter 5.6.2
  2. Configure plugin manager and install jpgc-graphs-additional,jpgc-graphs-basic,jpgc-casutg plugins initial state jmeter_plugins_initial_state plugins to install jmeter_plugins_installed1
  3. Check plugins installed and available new thread groups are available custom_tg_available new listeners are available custom_listeners_available
  4. Install bzm-http2 plugin jmeter_plugins_installed2
  5. Check previously installed pluging new thread groups from #3 are gone custom_tg_not_available new listeners from #3 are available custom_listeners_not_available jpgc-casutg still shown as installed (but TG are not available). jpgc-graphs-additional,jpgc-graphs-basic disappeared from installed. jmeter_plugins_installed3
diego-ferrand commented 2 months ago

Hey @syampol13, thank you for reporting this. The issue is due to installation logic for http2 plugin. It manually upgrades jetty and all dependency used, they are all deleted and installed again which might cause some other plugins to be uninstalled.

With the plugins you identified, there is a shared dependency which is being uninstalled and installed by http2 plugin: jmeter-plugins-cmn-jmeter

This has been fixed and will be included in next release. For now, you can simply install the plugins again.