[REVIEW] Support for IS NOT FALSE condition

BlazingDB / blazingsql

BlazingSQL is a lightweight, GPU accelerated, SQL engine for Python. Built on RAPIDS cuDF.

https://blazingsql.com

Apache License 2.0

1.92k stars 181 forks source link

[REVIEW] Support for IS NOT FALSE condition #1455

Closed Christian8491 closed 3 years ago

Christian8491 commented 3 years ago

This PR closes #1446 . This PR also enables booleanTest to use null values.

Some of these changes are related to fix 0.20 dependency conflicts and cuda compiler issues cc @mario21ic @romulo-auccapuclla .

As we know in order to support cuda version 11 (as discussed here https://github.com/rapidsai/rmm/issues/736) we need to update our cuda driver versions (450) as http://docs.nvidia.com/deploy/cuda-compatibility/index.html suggest

Finally it's expected that all the cuda-10.X jobs fails.

Christian8491 commented 3 years ago

rerun tests

Christian8491 commented 3 years ago

rerun tests

wmalpica commented 3 years ago

rerun tests

Christian8491 commented 3 years ago

rerun tests

wmalpica commented 3 years ago

@Christian8491 column_A IS NOT FALSE seems to evaluate to just column_A, but, have you checked to make sure that that logic holds true with nulls?

Christian8491 commented 3 years ago

@williamBlazing I will test using nulls and see what is the behavior.

Christian8491 commented 3 years ago

rerun tests

mario21ic commented 3 years ago

rerun tests

romulo-auccapuclla commented 3 years ago

rerun tests

mario21ic commented 3 years ago

rerun tests