search

BlazingDB / blazingsql

BlazingSQL is a lightweight, GPU accelerated, SQL engine for Python. Built on RAPIDS cuDF.
https://blazingsql.com
Apache License 2.0
1.93k stars 183 forks source link

[REVIEW] Improve test script for blazingsql-testing-file #1482

Closed mario21ic closed 3 years ago

mario21ic commented 3 years ago

This PR fixes #1474

In this job https://gpuci.gpuopenanalytics.com/job/blazingsql/job/gpuci/job/blazingsql/job/prb/job/blazingsql-gpu-build/2810/consoleText the branch was https://github.com/blazingdb/blazingsql-testing-files/tree/feat/master

Then I made a fork from https://github.com/blazingdb/blazingsql-testing-files After that, this job https://gpuci.gpuopenanalytics.com/job/blazingsql/job/gpuci/job/blazingsql/job/prb/job/blazingsql-gpu-build/2813/consoleText cloned the repo from https://github.com/mario21ic/blazingsql-testing-files/tree/feat/data-branch

GPUtester commented 3 years ago

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

mario21ic commented 3 years ago

rerun tests

wmalpica commented 3 years ago

@mario21ic we actually dont want to use the master branch. We want to use branch-0.20 in this case. Or a branch with the same name as the target branch of the PR. So if the PR is targeting branch-0.20 then it should try to use a branch-0.20 in blazingsql-testing-files if the PR is targeting branch-0.21 then it should try to use a branch-0.21 in blazingsql-testing-files, ... etc You will need to create the branch-0.20 in blazingsql-testing-files in the BlazingDB fork for this to work

mario21ic commented 3 years ago

rerun tests

mario21ic commented 3 years ago

rerun tests

mario21ic commented 3 years ago

rerun tests

mario21ic commented 3 years ago

@williamBlazing @felipeblazing the repository blazingsql-testing-files is cloned from the user's fork branch. Otherwise, the default branch to clone is branch-0.20 which will be changed according to new releases.