search

BlazingDB / blazingsql

BlazingSQL is a lightweight, GPU accelerated, SQL engine for Python. Built on RAPIDS cuDF.
https://blazingsql.com
Apache License 2.0
1.92k stars 181 forks source link

[REVIEW] support ORDERing null values #1539

Closed Christian8491 closed 3 years ago

Christian8491 commented 3 years ago

This PR closes #1513. As a summary what this PR does is:

col_x: val1 | null | val2 | val0 | null

order by col_x ASC: val0 | val1 | val2 | null | null

order by col_x DESC: null | null | val2 | val1 | val0

order by col_x NULLS LAST: (same as ASC) val0 | val1 | val2 | null | null

order by col_x NULLS FIRST: null | null | val0 | val1 | val2

order by col_x DESC NULLS FIRST: (same as DESC) null | null | val2 | val1 | val0

order by col_x DESC NULLS LAST: val2 | val1 | val0 | null | null

Related to https://github.com/BlazingDB/blazingsql-testing-files/pull/31 which adds tests for this feature.

GPUtester commented 3 years ago

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Christian8491 commented 3 years ago

@williamBlazing could you reopen this PR pointing to the "new" branch-21.06

Christian8491 commented 3 years ago

rerun tests