search

BlazingDB / blazingsql

BlazingSQL is a lightweight, GPU accelerated, SQL engine for Python. Built on RAPIDS cuDF.
https://blazingsql.com
Apache License 2.0
1.92k stars 181 forks source link

[REVIEW] Fix `CC`/`CXX` variables in CI #1576

Closed ajschmidt8 closed 3 years ago

ajschmidt8 commented 3 years ago

This PR adds CC, CXX, and CUDAHOSTCXX entries to the build.script_env section of the conda recipe, so that those environment variables get passed through the build.sh script and ultimately to CMake. This enables CMake to use the correct versions of gcc and g++ when compiling.

Additionally, it includes some fixes for the upstream cudf changes in https://github.com/rapidsai/cudf/pull/8142

GPUtester commented 3 years ago

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

ajschmidt8 commented 3 years ago

@wmalpica, @felipeblazing, looks like the failures here are unrelated to this PR. You should notice in the CI logs here that CMake is now using gcc 9 (instead of gcc 4 as shown in the logs in #1574 for example) which is good.

ajschmidt8 commented 3 years ago

looks like the error in the image below (log link) could be related to https://github.com/rapidsai/cudf/pull/8142

image

ajschmidt8 commented 3 years ago

pushed some fixes in 1b2ba51

ajschmidt8 commented 3 years ago

the latest commit seemed to fix some of the build errors, but not all of them. continuing to look into this locally. the last outstanding error messages are these (log link):

image

ajschmidt8 commented 3 years ago

rerun tests

trxcllnt commented 3 years ago

rerun tests

jakirkham commented 3 years ago

rerun tests

Christian8491 commented 3 years ago

rerun tests

Christian8491 commented 3 years ago

@ajschmidt8 I've found out the issue (at least for the concatSuite test) related to these last gpuci-jobs failures. Could you provide me permission to push into your own fork ? Or Do you prefer i share with you the delta.patch so you can push these changes from your side ?

ajschmidt8 commented 3 years ago

@ajschmidt8 I've found out the issue (at least for the concatSuite test) related to these last gpuci-jobs failures. Could you provide me permission to push into your own fork ? Or Do you prefer i share with you the delta.patch so you can push these changes from your side ?

@Christian8491, I do have the box selected to allow edits from maintainers, so you should be able to push. But if you want to share the patch with me, that's fine too! Whatever works.

jakirkham commented 3 years ago

Thanks for helping out here Christian! 😄

While CI is running, do you or others have thoughts on the changes AJ included here?

Christian8491 commented 3 years ago

@romulo-auccapuclla @mario21ic do you guys have some comments/thoughts about this PR ?

Christian8491 commented 3 years ago

rerun tests

Christian8491 commented 3 years ago

rerun tests

jakirkham commented 3 years ago

Thanks all! 😀