Closed Arcnor closed 1 year ago
Many thanks for this! I've left a few comments, I'll be able to have a deeper look tomorrow.
In the meantime, could you please split this into a separate commits.
These should probably be added piecemeal, one-by-one as we get them working.
I'd suggest one adding dosbase
, then one for the tutorials (they're simple enough they can be added all-at-once), and one for each of the 1.2 examples.
Also related: https://github.com/crocguy0688/CrocDE-BRender/issues/16
Many thanks for this! I've left a few comments, I'll be able to have a deeper look tomorrow.
In the meantime, could you please split this into a separate commits. These should probably be added piecemeal, one-by-one as we get them working. I'd suggest one adding
dosbase
, then one for the tutorials (they're simple enough they can be added all-at-once), and one for each of the 1.2 examples.
Do you want a separate PR for each commit, or all commits into this PR?
Do you want a separate PR for each commit, or all commits into this PR?
A separate PR with dosbase and the tutorials would be good as they mostly seem complete.
The other examples seem to still need some work, so keep them in this one.
Do you want a separate PR for each commit, or all commits into this PR?
A separate PR with dosbase and the tutorials would be good as they mostly seem complete.
The other examples seem to still need some work, so keep them in this one.
Done at #21
As the title mentions, this adds (most of) the samples and tutorials of BRender v1.2. I've tried to keep changes to a minimum, and from the top of my head, those changes are initialization (to add all the SDL stuff), creating the camera (so the aspect ratio is correct) and changing the main loop to update SDL.
Some of the samples might not compile as I was toying with them to try and fix the issues I found, but I think almost everything does (also can't test right now because I'm on my Windows machine and the project doesn't compile cleanly here. I have changes to make that happen but they're not cross platform, so I haven't included them anywhere).
Finally, I haven't bothered with adding back the input handling although I started to do it on the
fly
sample, where I added events for key handling.