search

BlazingSolutions / TimeKeeper

A project for learning Blazor
9 stars 0 forks source link

Apply themes for client and server projects #52

Closed DotNetDublin closed 3 years ago

DotNetDublin commented 3 years ago

As discussed in issue #51 @harperjohn suggested it would be nice to be able to easily identify whether you were viewing the client (wasm) or server version of the application.

Taking inspiration from https://mudblazor.com/customization/theming/overview I've now set the WASM version to employ a dark theme as shown below.

I currently evaluate whether the application is the client version by the URL which is hard coded to localhost:44360.

In a separate issue / pull request we can look at moving any hardcoded references to localhost to configuration files.

client-side

server-side

harperjohn commented 3 years ago

@DotNetDublin I have mostly used Git on our local LANS at work, and we have used our own separate version management process.... and with Github I have mostly used it for my solo projects.

What process do I follow when I get a "review request"?

I saw the "view" files and I looked at the changes.

I would like to run this code too... is it in a named branch?

ohh.... wait a minute... I think I see that it is in the "application-branding" branch... I will check that out now.

DotNetDublin commented 3 years ago

I see you found it @harperjohn which is great and I too am new to GitHub as I don't use it for work.

My process was

  1. Created the branch application-branding on GitHub
  2. Pulled the remote branch
  3. Made the changes and pushed to the application-branding branch
  4. Create pull request including providing an overview of the changes made.

I think for steps 1 and 2 you could probably create the branch locally first but above is the way I did it this time.

harperjohn commented 3 years ago

Great! Those steps make perfect sense! But it was nice to see/confirm them thanks!

So I viewed the changes and ran the app. Looks good to me (nice job! BTW) for a "merge with main".

jonhilt commented 3 years ago

Hey @DotNetDublin, looks good to me too :-)

I'm aware people talk about refactoring a lot, but it's not always obvious what refactoring actually looks like, or how to approach it.

Looking at this feature it feels like a great candidate for some incremental refactoring.

So, I would say go ahead with merging this in, and if I get a moment I'll try to record a quick video of me attempting a spot of refactoring from this starting point 👍

DotNetDublin commented 3 years ago

Thanks @jonhilt and seeing how you would refactor would be great.