Blazingstix / QFGImporter

My current attempt at fully exploring the Quest For Glory import sav file contents.
https://blazingstix.com
GNU General Public License v2.0
14 stars 5 forks source link

Add missing flags #9

Closed lwcorp closed 2 years ago

lwcorp commented 2 years ago

QFG2 is the only one in which you revealed all flags.

Since I see you started progress again, does it mean there's hope you'll uncover those mysterious flags...? I know you did it in the source code years ago, but you never made a new release (nor did you update the README about QFG3/4). image

QFG1: Only 1 flag left to reveal: image

QFG2: You already revealed all flags, how cool is that? image

QFG3: Only 1 item is revealed: image

QFG4: None of the flags are revealed: image

lwcorp commented 2 years ago

Here's the entire solution:

QFG1:

Code reference: https://github.com/EricOakford/SCI-Decompilation-Archive/blob/master/qfg1vga/src/CharSave.sc#L148

QFG2: Already perfect, nothing needs to be done.

QFG3:

Code reference: https://github.com/EricOakford/SCI-Decompilation-Archive/blob/master/qfg3/src/CharSave.sc#L189

QFG4:

Code reference: https://github.com/EricOakford/SCI-Decompilation-Archive/blob/master/qfg4cd/src/CharSave.sc#L174

Blazingstix commented 2 years ago

Thanks for the detailed legwork, Iwcorp. I had forgotten that I had already implemented almost all of your Flag renaming suggestions into the source code, but I had not published them before.

I took the opportunity now to dig into the final remaining unknown items, and I have fully identified everything. I used a combination of ErikOakford's decompilation archive that you referenced, as well as decompilations of my own.

And I have now finally published the latest version. V2.0.

lwcorp commented 2 years ago

Thanks! Will you post it in your website too? I suggest just remove the download link there and link instead to https://github.com/Blazingstix/QFGImporter/releases.