context menu and node right click

[pfh59]

Hi,

Sorry for my late reply,

In attachement a video to describe right click issue. Environnement :

• osx : ventura 13.4
• Safari : 16.5

1. Left click stay pressed :
   • moving mouse
   • node move : => no problem 🎉 ✅
2. Right click pressed or stay pressed:
   • Browser popup appear 😵‍💫
   • Left click to remove popup and the focus stay on node
   • Move your move without any button pressed => Node still moving without any mouse buttons pressed... 🚫

https://github.com/Blazor-Diagrams/Blazor.Diagrams/assets/109206285/837f11cb-9611-4176-9a7f-d5e684a820ac

I find a workaround, I remove DragMoveBehavior and add my owned DragMoveBehavior

Originally posted by @pfh59 in https://github.com/Blazor-Diagrams/Blazor.Diagrams/discussions/318#discussioncomment-6062709

[pfh59]

You can find here my CustomDragMovablesBehavior class:

using Blazor.Diagrams.Core.Geometry;
using Blazor.Diagrams.Core.Models.Base;
using Blazor.Diagrams.Core.Events;
using System;
using System.Collections.Generic;
using Blazor.Diagrams.Core.Models;
using Blazor.Diagrams.Core;

namespace WHMapper.Pages.Mapper
{
    public class CustomDragMovablesBehavior : Behavior
    {
        private readonly Dictionary<MovableModel, Point> _initialPositions;
        private double? _lastClientX;
        private double? _lastClientY;
        private bool _moved;

        public CustomDragMovablesBehavior(Diagram diagram) : base(diagram)
        {
            _initialPositions = new Dictionary<MovableModel, Point>();
            Diagram.PointerDown += OnPointerDown;
            Diagram.PointerMove += OnPointerMove;
            Diagram.PointerUp += OnPointerUp;
        }

        private void OnPointerDown(Model? model, PointerEventArgs e)
        {
            if (model is not MovableModel || e.Button != 0)
                return;

            _initialPositions.Clear();
            foreach (var sm in Diagram.GetSelectedModels())
            {
                if (sm is not MovableModel movable || movable.Locked)
                    continue;

                // Special case: groups without auto size on
                if (sm is NodeModel node && node.Group != null && !node.Group.AutoSize)
                    continue;

                var position = movable.Position;
                if (Diagram.Options.GridSnapToCenter && movable is NodeModel n)
                {
                    position = new Point(movable.Position.X + (n.Size?.Width ?? 0) / 2,
                        movable.Position.Y + (n.Size?.Height ?? 0) / 2);
                }

                _initialPositions.Add(movable, position);
            }

            _lastClientX = e.ClientX;
            _lastClientY = e.ClientY;
            _moved = false;
        }

        private void OnPointerMove(Model? model, PointerEventArgs e)
        {
            if (_initialPositions.Count == 0 || _lastClientX == null || _lastClientY == null)
                return;

            _moved = true;
            var deltaX = (e.ClientX - _lastClientX.Value) / Diagram.Zoom;
            var deltaY = (e.ClientY - _lastClientY.Value) / Diagram.Zoom;

            foreach (var (movable, initialPosition) in _initialPositions)
            {
                var ndx = ApplyGridSize(deltaX + initialPosition.X);
                var ndy = ApplyGridSize(deltaY + initialPosition.Y);
                if (Diagram.Options.GridSnapToCenter && movable is NodeModel node)
                {
                    node.SetPosition(ndx - (node.Size?.Width ?? 0) / 2, ndy - (node.Size?.Height ?? 0) / 2);
                }
                else
                {
                    movable.SetPosition(ndx, ndy);
                }
            }
        }

        private void OnPointerUp(Model? model, PointerEventArgs e)
        {
            if (_initialPositions.Count == 0 || e.Button != 0)
                return;

            if (_moved)
            {
                foreach (var (movable, _) in _initialPositions)
                {
                    movable.TriggerMoved();
                }
            }

            _initialPositions.Clear();
            _lastClientX = null;
            _lastClientY = null;
        }

        private double ApplyGridSize(double n)
        {
            if (Diagram.Options.GridSize == null)
                return n;

            var gridSize = Diagram.Options.GridSize.Value;

            // 20 * floor((100 + 10) / 20) = 20 * 5 = 100
            // 20 * floor((105 + 10) / 20) = 20 * 5 = 100
            // 20 * floor((110 + 10) / 20) = 20 * 6 = 120
            return gridSize * Math.Floor((n + gridSize / 2.0) / gridSize);
        }

        public override void Dispose()
        {
            _initialPositions.Clear();

            Diagram.PointerDown -= OnPointerDown;
            Diagram.PointerMove -= OnPointerMove;
            Diagram.PointerUp -= OnPointerUp;
        }
    }
}

[zHaytam]

So you're now checking to see if its a left click first, great! That's exactly what I would've suggested.

I will add this fix to the next version