Blazor-Diagrams / Blazor.Diagrams

A fully customizable and extensible all-purpose diagrams library for Blazor
https://blazor-diagrams.zhaytam.com
MIT License
919 stars 176 forks source link

JavaScript conflict variables #345

Open anlugifa opened 10 months ago

anlugifa commented 10 months ago

Hi, I am currently using 2.1.6 version and it seems others libraries are also using a js variable names 's', which causes a lot of bugs during rendering. Please, change the variable 's' to some name more complex (to be exclusive). Of course, others libraries should do the same.

From script.js:

var s = { canvases: {}, tracked: {},

zHaytam commented 8 months ago

I'm not sure why that name s would cause an issue with renders since at the end, the most important part in our js is window.ZBlazorDiagrams = s; and we use window.ZBlazorDiagrams, not s.

Even if I change it in script.js, you would be using script.min.js and since it's minified, we have no control over it.

Tell me if this is still an issue for you so that I modify it if needed!