search

Blazor-Diagrams / Blazor.Diagrams

A fully customizable and extensible all-purpose diagrams library for Blazor
https://blazor-diagrams.zhaytam.com
MIT License
917 stars 176 forks source link

Handle null Rectangle #413

Closed Heathermcx closed 3 months ago

Heathermcx commented 4 months ago

Handle null rectangle gracefully so that diagram can render in unit test without JS.

zHaytam commented 4 months ago

Hello, thanks for the PR!

I am wondering why can't we mock the JS call in unit tests and set a rectangle as we want. Making it nullable doesn't seem okay to me since we're supposed to have the bounds of the diagram, otherwise many features fail.

GeertvanHorrik commented 4 months ago

Nice PR, was going to do the same, thanks for the effort :)

Heathermcx commented 3 months ago

Thank you for the feedback. We have decided that we will mock the JS for our tests.