search

BlazorExtensions / Logging

Microsoft Extension Logging implementation for Blazor
MIT License
216 stars 31 forks source link

Updates to work with Blazor 3.0.0-preview4 #25

Closed DanielCarmingham closed 5 years ago

DanielCarmingham commented 5 years ago

Minimal changes to get it working with Blazor 3.0.0-preview4.

galvesribeiro commented 5 years ago

Thanks again @DanielCarmingham! Reviewing/merging soon!

Hawxy commented 5 years ago

This might not be relevant for this project (since it doesn't distribute any razor components as far as I can tell), but as a note for the other projects you're updating, component libraries should (probably) be updated to the new Blazor Library template.

Microsoft.NET.Sdk.Web -> Microsoft.NET.Sdk.Razor

Remove <OutputType> Add <AddRazorSupportForMvc>true</AddRazorSupportForMvc> (To be removed in next preview version)

Remove any Microsoft.AspNetCore.Blazor.* references and change it to a single Microsoft.AspNetCore.Components.Browser reference

If you come across a global.json (as with BlazorMaterial), that can also be deleted.

DanielCarmingham commented 5 years ago

Added another commit with the changes recommended by @Hawxy to make it more similar to the blazorlib templates:

Although these don't provide any direct benefit here, I added these to be consistent with the blazorlib template. (I find it makes it easier to upgrade between Blazor releases when you can easily see the changes.)

If you'd rather pull these out, just let me know, I could go either way on this...

Thanks, Daniel

galvesribeiro commented 5 years ago

@DanielCarmingham thanks again for doing this.

Can you do me a favor and let me know on all the PRs you made when it is done for review?

Thank you!

DanielCarmingham commented 5 years ago

@galvesribeiro Yeah, sorry about that. My initial attempt was to do as little as possible to get them working on 3.0.0-preview4. However, as @Hawxy pointed out, there are some things that, even though they work, aren't quite right.

This one is ready for review. I'll comment on the other repos individually. THANK YOU for your efforts on these projects and for taking the time to review my PR. I sincerely appreciate it.

Thanks, Daniel

galvesribeiro commented 5 years ago

Thank you @DanielCarmingham !!!

IvanJosipovic commented 5 years ago

@galvesribeiro We're still missing the nuget update.

galvesribeiro commented 5 years ago

The updates for all the packages will come tonight. I need to reset the NuGet key on all Azure Pipeline build definitions so it can push the packages (they expired). Hang on!