search

BlazorExtensions / Logging

Microsoft Extension Logging implementation for Blazor
MIT License
216 stars 31 forks source link

3.0.0-preview6 changes #30

Closed MarkStega closed 5 years ago

MarkStega commented 5 years ago

Modest changes required for preview6 compatibility; Used Newtonsoft.Json rather than System.Text.Json after running into serialization/deserialization issues in another project. This can be revisited after System.Text.Json stabilizes.

StevenTCramer commented 5 years ago

Thank's Mark for doing this PR

MarkStega commented 5 years ago

I suspect that the CI build failure is because the CLI is preview4

galvesribeiro commented 5 years ago

Hello @MarkStega , can you update the PR so the build pass? Thank you!

MarkStega commented 5 years ago

@galvesribeiro The CI build failure was likely caused because the CLI in the build was preview4. The build logs are no longer available. I believe if you update the build environment to preview6 & force a rebuild all will be well.

chucker commented 5 years ago

The CI build failure was likely caused because the CLI in the build was preview4.

I think @galvesribeiro is asking if you could edit the .vsts-ci.yml file accordingly in your PR.

MarkStega commented 5 years ago

@chucker I didn't know that there were yml files in the solution or what they were for. I updated the SDK version as well as adding them as solution items so that they were visible when using Visual Studio.

Thanks for the clarification/education.

MarkStega commented 5 years ago

@galvesribeiro With the assistance of @chucker I discovered that yml files were part of the project and what their use was. They are now updated & the CI build passes.

galvesribeiro commented 5 years ago

Thank you both!