Blazored / FluentValidation

A library for using FluentValidation with Blazor
https://blazored.github.io/FluentValidation/
MIT License
581 stars 84 forks source link

[Bug] OnFieldChanged validates field using validator for owning instance type, not the one for EditContext.Model type #235

Open hakenr opened 1 week ago

hakenr commented 1 week ago

Describe the bug Assume we have a complex type from this documentation: https://docs.fluentvalidation.net/en/latest/start.html#complex-properties
There is a Customer class with an Address property and two validators: CustomerValidator and AddressValidator.

Let’s remove this line from the CustomerValidator:

public class CustomerValidator : AbstractValidator<Customer> 
{
  public CustomerValidator()
  {
    RuleFor(customer => customer.Name).NotNull();
-   RuleFor(customer => customer.Address).SetValidator(new AddressValidator());
  }
}

The AddressValidator still exists:

public class AddressValidator : AbstractValidator<Address> 
{
  public AddressValidator()
  {
    RuleFor(address => address.Postcode).NotNull();
    // etc.
  }
}

Now, when you create this type of UI (shortened for brevity):

<EditForm Model="company">
  <FluentValidationValidator />
  <InputText @bind-Value="company.Address.Postcode" />

The FluentValidationValidator validates the Postcode field using the AddressValidator, even though the CompanyValidator for the Model does not reference the AddressValidator, and companyValidator.Validate() does not use the AddressValidator. The Postcode field should not be validated in this case.

Expected behavior The validator for the Model (CustomerValidator) should be used for all field validations, company.Address.Postcode should not be validated as CustomerValidator does not reference AddressValidator.

Additional context https://github.com/Blazored/FluentValidation/blob/f02c9beb6489574b91bb20c2a2257a6f2339eb67/src/Blazored.FluentValidation/EditContextFluentValidationExtensions.cs#L84-L105
I believe the issue is in how the ValidateField() method is implemented. It uses fieldIdentifier.Model directly and does not take editContext.Model into account. The implementation won’t be trivial (you cannot simply replace fieldIdentifier.Model with editContext.Model as someone has already tried), but it is doable.

Related items:

cc @jirikanda