search

Blazored / Gitter

A Blazor Gitter Client
MIT License
37 stars 14 forks source link

Feature configuration #58

Closed MarkStega closed 4 years ago

MarkStega commented 5 years ago

This is a first pass at a configuration component. It is not integrated into the gitter client at this time. There is a project called Blazor.Gitter.Settings that should be set as the startup project to see the settings in action (Both reading current settings (the home page) as well as invoking the settings dialog (the settings page)). I can spend as much time as you want reviewing how this works as I did not do a 'quick & dirty' but instead built the setting component up through multiple layers.

I know that more choices are needed for the accent color (please suggest what you would like to see).

[Edit] I believe that the cumber of commits in this PR is caused by my update of the feature branch to the current master contents. I am not in any way shape or form a git expert so it is also possible that I messed something up. I'd work with this PR in a local repository just to be safe.

SQL-MisterMagoo commented 5 years ago

Thanks @MarkStega - I'll try to find some time to take a proper look.

One thing that jumps out at me is the custom button - why not just use a button rather than a span with an onclick?

SQL-MisterMagoo commented 5 years ago

Don't worry about the commits, we can cherry pick or squash or some other strange git thing to sort that

MarkStega commented 5 years ago

I'm absolutely not wedded to the csss/html stuff; The components used to build up the settings dialog I stole from a work in progress application that does not use bootstrap as it's base styling (It is all DIY). So any changes will not hurt my feelings at all. It's code, I have no attachment :-)