search

Blazored / Gitter

A Blazor Gitter Client
MIT License
37 stars 14 forks source link

2019-09-17 DNC 3.0.0 RC1 & Settings update #68

Closed MarkStega closed 4 years ago

MarkStega commented 4 years ago

@sql-mistermagoo @chrissainty This PR has a much cleaner implementation of the settings dialog as well as support for DNC 3.0.0 RC1

There is a sample project called Blazor.Gitter.Settings which is a server side demo of the settings dialog. This entire project can be deleted once the settings dialog is fully integrated. I left it in place only to show how setting work without the css difficulties.

Missing (and I need help): 1) The settings page is being rendered but with really odd placement of the h1 title and the invoke button. 2) The settings page when invoked needs css styling. 3) The resultant settings are not used in Blazored.Gitter.

SQL-MisterMagoo commented 4 years ago

Thanks Mark - I'll pull this down and have a look

MarkStega commented 4 years ago

@SQL-MisterMagoo I solved the issue of why the settings dialog was not getting rendered. Now I think it just needs major css help on the settings page & the dialog as well as then actually using the settings.

SQL-MisterMagoo commented 4 years ago

We never got around to implementing this - and it is very far behind now - maybe we can cherry pick some commits from it if we get back to adding settings.

Thanks for the PR.

chucker commented 4 years ago

Is there a screenshot or sketch of what this settings dialog did?

SQL-MisterMagoo commented 4 years ago

I can probably force it to run and get one

On Wed, 3 Jun 2020, 01:57 Sören Nils Kuklau, notifications@github.com wrote:

Is there a screenshot or sketch of what this settings dialog did?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Blazored/Gitter/pull/68#issuecomment-637891554, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWQFPTGUHADPSYTIZUP7ODRUWNWFANCNFSM4IXPYSVA .