Move chat.js to use TypeScript

Blazored / Gitter

A Blazor Gitter Client

MIT License

37 stars 14 forks source link

Move chat.js to use TypeScript #76

Closed chucker closed 4 years ago

chucker commented 4 years ago

Sure, sorry about that. I’ll have a look!

SQL-MisterMagoo commented 4 years ago

It could be something I'm missing locally but it complains about IDisposable not found etc. Very odd

On Tue, 2 Jun 2020, 17:51 Sören Nils Kuklau, notifications@github.com wrote:

Sure, sorry about that. I’ll have a look!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Blazored/Gitter/pull/76#issuecomment-637677205, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWQFPVNJYBJE25DRO4ZQSLRUUUXVANCNFSM4NMPTVJA .

chucker commented 4 years ago

I tried on a second system and it seemed to have trouble finding gulp (which in turn causes the Core project to fail to build). Maybe that's what you ran into. Try again with the minor change I just pushed.

SQL-MisterMagoo commented 4 years ago

I was still seeing errors with this, but I deleted node_modules (ugh I hate that folder) and removed Microsoft.TypeScript.MSBuild and it built, then I reset the branch back to your last commit and rebuilt and it built - my guess is something in my node_modules folder was wrong. Anyway I think we'll plough on as we are now.

chucker commented 4 years ago

ugh I hate that folder

Aye. Gulp was already there so I built on top of it, but ideally, we’d avoid the npm ecosystem here.

That’s for another PR. Someday.