Blazored / Toast

A JavaScript free toast library for Blazor and Razor Component applications
https://blazored.github.io/Toast/
MIT License
654 stars 90 forks source link

Adds new DisableTimeout setting #206

Closed chrissainty closed 1 year ago

chrissainty commented 1 year ago

Resolves #193

Cvijo commented 1 year ago

hi @chrissainty, I think you will need to add instanceToastSettings.DisableTimeout ??= DisableTimeout; to BuildCustomToastSetting too, i think it would be null if they don't set it on instance settings and this line Settings.DisableTimeout!.Value would throw error i think

    private ToastSettings BuildCustomToastSettings(Action<ToastSettings>? settings)
    {
        var instanceToastSettings = new ToastSettings();
        settings?.Invoke(instanceToastSettings);
        instanceToastSettings.DisableTimeout ??= DisableTimeout; **<-- this line**

        return instanceToastSettings;
    }
chrissainty commented 1 year ago

@Cvijo Great spot!