search

Blazored / Toast

A JavaScript free toast library for Blazor and Razor Component applications
https://blazored.github.io/Toast/
MIT License
663 stars 92 forks source link

[Feature Request] Make the behaviour of the heading setting more predictable #94

Closed blacksmith01 closed 2 years ago

blacksmith01 commented 3 years ago

Is there any way I can use it as below?

Toastify

blacksmith01 commented 3 years ago

Oh, I find a way. I can use heading parameter for message. like ShowSuccess("","This is a toast")

esso23 commented 3 years ago

Requesting reopen: First parameter of ShowSuccess is message and second is heading (with a default value of ""). If I request a heading with value "", I should get a heading with value "" (empty), not a heading with value "INFO".

I would propose setting default value of heading to "INFO" - as is displayed. Setting null should hide the heading. This would be much clearer than the current solution.

BewaAutomatisierung-RD commented 3 years ago

null and string.Empty should both make heading dissappear (and no empty space should be taken for the nonexisting header)

blacksmith01 commented 3 years ago

I agree with eso23's suggestion. I was expecting that at first, too. It will be nice if Chris update it.

Rowingwolf commented 3 years ago

I agree. Would like to suppress the heading, especially for info toasts.

chrissainty commented 3 years ago

As this would be a breaking change I'm going to leave it for now. I'm about to push a bit set of updates which are non-breaking and I'd like them to bed in before adding a breaking change.

ltemimi commented 2 years ago

has this been done I do not want a capital header

chrissainty commented 2 years ago

Closing as headings are being removed from the default toasts in the next release (see #170)