Blazored / Typeahead

Typeahead control for Blazor applications
https://blazored.github.io/Typeahead/
MIT License
436 stars 103 forks source link

TwoWay Binding of Value #35

Closed ScholliYT closed 5 years ago

ScholliYT commented 5 years ago

I want to set the currently selected Value from the outside. Looks like we need to add some kind of UI state refresh if Value changes.

I might make up a PR for this.

vertonghenb commented 5 years ago

This should already be supported since we "refresh the UI" OnParametersSet https://github.com/Blazored/Typeahead/blob/b3f38b891cd536c9c4590a9d57d86ad1673f5f49/src/Blazored.Typeahead/Forms/BlazoredTypeaheadInput.razor.cs#L96

I'm not sure which version you're currently using, but the latest version is not out yet which would fix this issue. @chrissainty can we release the last PR? #31

chrissainty commented 5 years ago

I'm open to your opinion on this,@vertonghenb. But I would prefer we hold off releasing the current set of changes until Preview 9 lands, Dan Roth said that should be Tuesday or Wednesday next week.

This would avoid having to do two releases in quick succession and if we wait for Preview 9 we should hopefully get the fixes for Razor Class Libraries as well. There are more breaking APIs in Preview 9 as well. Which is going to be fun!

vertonghenb commented 5 years ago

@chrissainty agreed!

vertonghenb commented 5 years ago

@ScholliYT Closing this since the package was recently updated to preview-9 and this change was fixed by #31.