search

Blef-team / blef_game_engine

The game engine API service for the game of Blef
GNU Affero General Public License v3.0
1 stars 0 forks source link

Fix no response to join attempt with special characters #84

Closed adrian-golian closed 4 years ago

adrian-golian commented 4 years ago

Observed behaviour:

$ curl <BASE PATH>/games/ab0adc2c-28a4-4f54-9652-ff6156277507/join?nickname=Xylophonic_Xólotl
curl: (52) Empty reply from server
maciej-pomykala commented 4 years ago

The function does not get executed at all. I'm trying to find a solution for this, but it's taking a few moments so far.

adrian-golian commented 4 years ago

This is probably not an error with the game engine. I can call this endpoint like this, successfully:

curl -i -X GET -H "Content-Type: text/plain; charset=ISO-8859-1" <BASE PATH>/games/ab0adc2c-28a4-4f54-9652-ff6156277507/join? --data-ascii "nickname=Xylophonic_Xólotl"
adrian-golian commented 4 years ago

Opened Blef-team/blef_ios_app#28 to handle this issue. If you agree, we can close this.

maciej-pomykala commented 4 years ago

I have been able to locally (on Windows) transform the problem into the (possibly less disturbing) problem present in this link by using percent encoding - that is, Xólotl becomes X%C3%B3lotl.

maciej-pomykala commented 4 years ago

But the latter problem is Windows-specific and our API is running on Linux so I agree that, long story short, we can close this issue.

adrian-golian commented 4 years ago

Closing.