Refactor URLSession to use URLRequest

Blef-team / blef_ios_app

The iOS app for the game of Blef

Other

0 stars 0 forks source link

Refactor URLSession to use URLRequest #30

Open adrian-golian opened 4 years ago

adrian-golian commented 4 years ago

Closes #28

adrian-golian commented 4 years ago

This refactor has to categorically wait for the deployment of v2, which needs to include issue Blef-team/blef_game_engine#85 fixed. With the current http method (GET), requests break with GET method must not have a body.

adrian-golian commented 4 years ago

Leaving this until method types are changed.

adrian-golian commented 2 years ago

Blef-team/blef_game_engine#169 made Blef-team/blef_game_engine#85 irrelevant - unblocking this issue.

maciej-pomykala commented 2 years ago

What's your criteria for whether an endpoint should be queried with GET vs POST? It porbably doens't make a material difference, and I'd say that POST is, as a convention, for changing things and GET for viewing things, so I'm wondering if create and join should really be different methods (create doesn't send any data, but start doesn't either, except authentication; create gets you a UUID, but so does join).