BlenderKit / BlenderKit

Official BlenderKit add-on for Blender 3D. Documentation: https://github.com/BlenderKit/blenderkit/wiki
https://www.blenderkit.com
GNU General Public License v2.0
146 stars 24 forks source link

Asset display "thumbnail not avaliable" error after editing validated assets via website. #910

Closed Numbian closed 10 months ago

Numbian commented 11 months ago

Describe the bug

I have this bug from time to time, but I think I have figured it out to some extent.

How to reproduce this error (allegedly):

1) upload an asset with name "Test asset" and thumbnail "thumb.png" via plugin, 2) wait for the asset to be validated, 3) go to Blenderkit website and edit the asset, 4) change asset name to "Test asset (Rigged, 8k texture)", 5) save asset 6) upload a new thumbnail via the website with the filename "thumb2.png" 7) save the asset and check the thumbnail in Blenderkit plugin - it should show "thumbnail not avaliable" error.

I think special characters/numbers in asset name and/or thumbnail filename have something to do with this issue.

Expected behavior

No response

Screenshots/video

thum

Logs

No response

Environment

Additional information

No response

agajdosi commented 11 months ago

Hi @Numbian, thank you for the information. We have pushed the fix into the production server and this issue should be fixed. You can try it and let us know if the problem disappeared or is still present. On my side I am not able to reproduce.

Numbian commented 11 months ago

Please give me a few days, I'll try to replicate it on a model that is currently awaiting validation.

agajdosi commented 11 months ago

Oczywiście, dziękujemy 🥇

PetrDlouhy commented 10 months ago

As I have written under #909 I have released fix for website uploads on 27.11.2023. The asset is re-processed after each update in the edit dialog so removing special characters from the name can help as any other change in the asset.

@Numbian Please confirm the fix, so we can close this one.

Numbian commented 10 months ago

@PetrDlouhy @agajdosi

Guys, there is still something wrong here, but I think it is unlikely that someone randomly will do this and I don't see anyone else having this bug in the plugin. I think you can just close this issue and focus on more important stuff. I will keep experimenting when uploading new models and let you know in a new Issue if I gather more data about this.

Steps I used to replicate and fix below:

Screen from plugin: image

Steps to replicate: 1) upload this model with name "Leather business shoes" and "thumb.jpg" Link to model Link to unprocessed thumbnail I used 2) wait for validation --> at this point all works as intended 3) change asset name to "Leather business shoes (8k, test)" via the website, 4) save, --> didn't check if still ok 5) reupload the same thumbnail with another filename "thumb2.jpg" via website, 6) save, reopen blender. --> bugged

How to fix: 1) change the asset name back to "Leather business shoes" via website 2) save, reopen blender, --> works as intended image

PetrDlouhy commented 10 months ago

@Numbian Thank you very much for the detailed report.

I can confirm, that this happens to me too and I didn't have to rename the asset, it has name without any special character.

The problem seems to be still in the processing after thumbnail is uploaded from web. It seems like the 2046x2046 WebP image was not generated (other WebPs were OK).

I will look at this deeper, this seems to be like more general bug.