search

BlenderNeko / ComfyUI_Noise

6 nodes for ComfyUI that allows for more control and flexibility over noise to do e.g. variations or "un-sampling"
GNU General Public License v3.0
222 stars 19 forks source link

broken unsampler due to comfy breaking change. #12

Closed efdesign closed 7 months ago

efdesign commented 7 months ago

Hi, thanks for the good work done here. I was testing unsample and noticed the latest comfy broke it

the following

`def batch_area_memory(area): if xformers_enabled() or pytorch_attention_flash_attention():

TODO: these formulas are copied from maximum_batch_area below

    return (area / 20) * (1024 * 1024)
else:
    return (((area * 0.6) / 0.9) + 1024) * (1024 * 1024)`

seems is removed/renamed in from comfy with commit dd4ba68b6e93a562d9499eff34e50dbbbc8714e7

but it's referenced at

nodes.py line 225 comfy.model_management.load_models_gpu([model] + models, comfy.model_management.batch_area_memory(noise.shape[0] * noise.shape[2] * noise.shape[3]) + inference_memory)

putting it back in comfy fixes it. maybe there is a different funciton for the same.

Regards

efdesign commented 7 months ago

nevermind, I see the latest code you have already uses the new function.