search

BlenderNeko / ComfyUI_Noise

6 nodes for ComfyUI that allows for more control and flexibility over noise to do e.g. variations or "un-sampling"
GNU General Public License v3.0
222 stars 19 forks source link

Error occurred when executing BNK_Unsampler: #27

Open BNP1111 opened 3 months ago

BNP1111 commented 3 months ago

Error occurred when executing BNK_Unsampler:

module 'comfy.sample' has no attribute 'convert_cond'

File "D:\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Noise\nodes.py", line 221, in unsampler positive = comfy.sample.convert_cond(positive) ^^^^^^^^^^^^^^^^^^^^^^^^^

IntellectusPrime commented 3 months ago

i have the same problem, seems to happen since the newest comfy update.

alexruimy commented 3 months ago

happening here on an M1 mac too.

Evilinside3357 commented 3 months ago

I have the same problem here too:

!!! Exception during processing !!! Traceback (most recent call last): File "/content/drive/MyDrive/ComfyUI/execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "/content/drive/MyDrive/ComfyUI/execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "/content/drive/MyDrive/ComfyUI/execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "/content/drive/MyDrive/ComfyUI/custom_nodes/ComfyUI_Noise/nodes.py", line 221, in unsampler positive = comfy.sample.convert_cond(positive) AttributeError: module 'comfy.sample' has no attribute 'convert_cond'

Prompt executed in 495.29 seconds

TheChrisHatfield commented 3 months ago

You'll need to modify the "nodes.py" file based on error looks likes its calling to a function which has be deprecated or syntax change. " line 221 positive = comfy.sample.convert_cond(positive) Line 222 negative = comfy.sample.convert_cond(negative).

Dig through the changelog for Comfy UI, and find the equivalent or alternative, which is the big problem to solve.

paulKra commented 3 months ago

i had the same problem, you can replace the unsampler from this extensions with a combination of nodes from sample/custom_sampling, mostly SplitSigmas and flipSigmas, i couldn't find a way to replace the inject_noise node though, all options from standard comfy allow either no noise or full noise, but no partial additions. Does anyone know a way to circumvent this problem?

Edit: you an use the advanced latent operations for that, but getSigma still remains a mystery for me.