BlenderNeko / ComfyUI_TiledKSampler

Tiled samplers for ComfyUI
GNU General Public License v3.0
297 stars 17 forks source link

does not work #17

Closed cgpmo closed 10 months ago

cgpmo commented 10 months ago

Error occurred when executing BNK_TiledKSampler:

module 'comfy.sample' has no attribute 'get_additional_models'

File "C:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "C:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "C:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "C:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_TiledKSampler\nodes.py", line 311, in sample return sample_common(model, 'enable', seed, tile_width, tile_height, tiling_strategy, steps_total, cfg, sampler_name, scheduler, positive, negative, latent_image, steps_total-steps, steps_total, 'disable', denoise=1.0, preview=True) File "C:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_TiledKSampler\nodes.py", line 116, in sample_common modelPatches = comfy.sample.get_additional_models(positive, negative)

what is the problem? how to fix?

BlenderNeko commented 10 months ago

either revert to a commit before 08c2c28 or update ComfyUI. See also issue #15

cgpmo commented 10 months ago

Update ComfyUI didn't help Error occurred when executing BNK_TiledKSampler: get_additional_models() missing 1 required positional argument: 'dtype' File "D:\CUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu24.08.23\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "D:\CUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu24.08.23\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "D:\CUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu24.08.23\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "D:\CUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu24.08.23\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_TiledKSampler\nodes.py", line 311, in sample return sample_common(model, 'enable', seed, tile_width, tile_height, tiling_strategy, steps_total, cfg, sampler_name, scheduler, positive, negative, latent_image, steps_total-steps, steps_total, 'disable', denoise=1.0, preview=True) File "D:\CUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu24.08.23\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_TiledKSampler\nodes.py", line 116, in sample_common modelPatches = comfy.sample.get_additional_models(positive, negative)

Last ComfyUI with and without update git pull for TiledKSampler nothing helped

BlenderNeko commented 10 months ago

seems like something changed in comfy again, should be working again now when using latest version of both comfy and tiled sampler

cgpmo commented 10 months ago

It works now. Thank you.