search

BlenderVR / source

Blender Virtual Reality Main Code
52 stars 21 forks source link

Added objects not added on Slave nodes #43

Open PyrApple opened 8 years ago

PyrApple commented 8 years ago

scene.addObject() and the like add objects only on Master node. It seems that the list of objects to update* is not updated itself.

wphicks commented 7 years ago

@perezsaint, you mentioned that you have a fix for this? I would be very excited to get my hands on that code. There's a whole branch of development I've been putting off on another project because I didn't have time to tackle this bug. Even if you aren't sure it's ready for a PR, I'd love it if you could push that change to your own fork. I'd be happy to have a crack at any testing or finishing touches it needs, if you like.

perezsaint commented 7 years ago

Hey,

I will push it to my fork today. I will send you a message when I do.

Michael.

On Sep 26, 2016 4:06 PM, "William Hicks" notifications@github.com wrote:

@perezsaint https://github.com/perezsaint, you mentioned that you have a fix for this? I would be very excited to get my hands on that code. There's a whole branch of development I've been putting off on another project because I didn't have time to tackle this bug. Even if you aren't sure it's ready for a PR, I'd love it if you could push that change to your own fork. I'd be happy to have a crack at any testing or finishing touches it needs, if you like.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BlenderVR/source/issues/43#issuecomment-249681771, or mute the thread https://github.com/notifications/unsubscribe-auth/ANqwB9mh83nd6fqGV9qANQ4g9BNR0tTEks5quCW1gaJpZM4HexRo .

perezsaint commented 7 years ago

I pushed it to my fork. You can check it out there. The problem was that the new object overwrote the last object in the synchronizer because they both had the same name. I fixed it by checking whether the id was already a in the synchronizer. If it isn't, it means that it's a copy of the old object that we have to create.

perezsaint commented 7 years ago

48 Here is the pull request

wphicks commented 7 years ago

Thank you so much! I'll have a look at it soon and let you know if I run into any problems with it.