search

BlessCSS / bless

CSS Post-Processor
blesscss.com
MIT License
282 stars 60 forks source link

Add command line option to configure selector limit #30

Closed pianomansam closed 9 years ago

pianomansam commented 10 years ago

I've ran into instances where splitting CSS files at exactly 4095 still doesn't solve the IE9 issue. This pull request is for an update that lets you determine the limit at which the CSS will be split.

daan944 commented 9 years ago

Exactly what I needed. Please merge into Bless. Media queries prove to influence the CSS selector limit.

paulyoung commented 9 years ago

I believe that this is a symptom of an issue with the way v3 incorrectly handles media queries. Sorry to hear that this is an issue for people. v4 should fix this.

@pianomansam thanks for your time and contribution but unfortunately I'm going to close this without merging since I think making the selector limit configurable is the wrong thing to do. 4095 should work across the board, and if not there's a bug in the implementation.

daan944 commented 9 years ago

The fact that v3 is incorrectly handling media queries is the reason why v3 is completely useless in a modern site with mediaqueries that is developed with the mobile-first approach. I agree, adjusting the CSS selector limit for this reason is a bit backwards, but it circumvents the issue and makes Bless v3 usable again.

paulyoung commented 9 years ago

I understand your frustration. Introducing this to the API only to deprecate it immediately in the next version is not something I'm willing to do though, especially since it's results are entirely dependent on the input provided.

You can of course use @pianomansam's fork in the meantime.

Sorry to disappoint.

aabenoja commented 9 years ago

@paulyoung While I agree with you that it does not make sense to merge this in only to deprecate it not long after, it could provide a workaround for v3 users in the interim, including those who may not pick up v4 right away.

aabenoja commented 9 years ago

Even though v4 is far superior, I can imagine a few stragglers in adopting it simply for the minor api changes.