search

BlessCSS / bless

CSS Post-Processor
blesscss.com
MIT License
282 stars 60 forks source link

IE9 file size limit #41

Closed sushantanand closed 9 years ago

sushantanand commented 9 years ago

Apparently, IE9 has a file size limit of ~280kb as well. BlessCSS wouldn't help in addressing that, right? Or since the files are broken up and @imported, the file size limit is no longer an issue?

paulyoung commented 9 years ago

Bless doesn't directly address that but might indirectly bring the file sizes below the limit.

This was mentioned briefly in #31. I'd prefer to keep this project about selecter count and let something else handle file size.

shannonhochkins commented 8 years ago

@paulyoung, I'm not trying to have a sook, however the blesscss.com website states under 'what is it?' "Bless provides an elegant solution to a lesser-known bug in Internet Explorer which causes CSS to be completely ignored."

This is exactly what happens here, css is completely ignored after the 288kb limit, I think this would be a very nice feature to add into it.

paulyoung commented 8 years ago

I'm open to hearing what @BlessCSS/contributors think.

aabenoja commented 8 years ago

Assuming that your css file is under the selector limit, if after minification the file size is still greater than 280kb I'd be worried about other things. I feel the file size is too arbitrary a metric to manipulate, as opposed to selector count. A better idea would be an option to set the selector limit for the build.

shannonhochkins commented 8 years ago

@aabenoja I did actually go into bless and manually lower the limit and that did work, it would seem that if you have longer rules/selector names, this can blow out the file size dramatically, being able to manually specify a selector limit would help fix this problem as a hack though.

aabenoja commented 8 years ago

And how exactly is being able to specify a specific selector limit a hack?

mtscout6 commented 8 years ago

If he's using 3.x version it would be a hack. If you're using the newer alpha release that is a parameter that you can provide.

mtscout6 commented 8 years ago

Wait never mind, I thought we made that configurable, but doesn't look like it is: https://github.com/BlessCSS/bless/blob/master/src/chunk.js#L26

aabenoja commented 8 years ago

Can be easily pull requested though

shannonhochkins commented 8 years ago

I wouldn't mind that feature, basically it seems that even though we fall within the rules of the bless system, if the selector names are long, it will blow out the file size, so optionally changing this limit would be great!